Kever, > On 28.11.2018, at 03:06, Kever Yang <kever.y...@rock-chips.com> wrote: > > According to the emmc/sdcard index in dts alias, emmc is always 0 and > sdcard index is 1, let's update to using correct mmc number for distro > boot order in common header. > > SD card suppost to have higher priority so that people can boot into > the firmware in SD card, this is very convenient for developer try with > distro img from SUSE, Fedora and etc. Developer only need to 'dd' the > Distro image(which id download from OS vendor release) into SD card without > any modify and then we can boot it up directly.
You never addressed the review comment from Klaus (from the review in May): > Also prioritising SD card over eMMC does not make any sense to me. At least on > RK3399 and RK3368 the default ROM boot order is first eMMC then SD card. So > starting U-Boot from eMMC and then loading the Kernel from SD-card doesn’t > sound > right for me. This will change default behaviour and may break things for users in the field. Before we can move forward, we really need to establish a consensus on this and how users will be affected. While this doesn’t matter much for our boards, as we have logic to rewrite the default boot during boot-up anyway, I expect a lot of trouble for mainline users with their own boards... > Signed-off-by: Kever Yang <kever.y...@rock-chips.com> > --- > > Changes in v3: > - update the commit message > Series-changes: 2 > - update the commit message > > include/configs/rockchip-common.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/configs/rockchip-common.h > b/include/configs/rockchip-common.h > index 68e1105a4b..8a72613e52 100644 > --- a/include/configs/rockchip-common.h > +++ b/include/configs/rockchip-common.h > @@ -11,11 +11,11 @@ > > #ifndef CONFIG_SPL_BUILD > > -/* First try to boot from SD (index 0), then eMMC (index 1) */ > +/* First try to boot from SD (index 1), then eMMC (index 0) */ > #if CONFIG_IS_ENABLED(CMD_MMC) > #define BOOT_TARGET_MMC(func) \ > - func(MMC, mmc, 0) \ > - func(MMC, mmc, 1) > + func(MMC, mmc, 1) \ > + func(MMC, mmc, 0) > #else > #define BOOT_TARGET_MMC(func) > #endif > -- > 2.18.0 > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
