On Mon, Nov 19, 2018 at 8:10 AM Liviu Dudau <liviu.du...@foss.arm.com> wrote: > On Sun, Nov 18, 2018 at 06:48:07PM -0200, Otavio Salvador wrote: > > This allow for convenient use of QEMU machine to test loading of UBI > > filesystem. There are a couple of changes made together of this which > > are required: > > > > 1) The malloc must be at least 512 KiB to allow the use of UBI > > filesystem. We are going to enable it in a next patch. ... > I don't have much to say about the enabling of the UBI for some > platforms that I have my doubts that QEMU emulates them correctly, but I > guess it should be harmless. What I have issues here is you saying in > the commit message "The malloc must be *at least* 512 KiB" but here you > make it *exactly* 512KiB, ignoring the CONFIG_ENV_SIZE. Would it not be > better to keep the CONFIG_SYS_MALLOC_LEN to be (CONFIG_ENV_SIZE + 512 * 1024)?
Absolutely; I just sent a v2 doing that. -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750 _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
