On Thu, Nov 01, 2018 at 08:39:04AM +0100, Heinrich Schuchardt wrote:
> On 11/01/2018 05:47 AM, AKASHI Takahiro wrote:
> > From: Leif Lindholm <leif.lindh...@linaro.org>
> >
> > This patch provides enough implementation of the following protocols to
> > run EDKII's Shell.efi and UEFI SCT:
> >
> > * EfiHiiDatabaseProtocol
> > * EfiHiiStringProtocol
> >
> > Not implemented are:
> > * ExportPackageLists()
> > * RegisterPackageNotify()/UnregisterPackageNotify()
> > * SetKeyboardLayout() (i.e. *current* keyboard layout)
> >
>
> <snip />
>
> > + case EFI_HII_PACKAGE_STRINGS:
> > + ret = add_strings_package(hii,
> > + (struct efi_hii_strings_package *)package);
>
> scripts/checkpatch.pl:
>
> CHECK: Alignment should match open parenthesis
> #583: FILE: lib/efi_loader/efi_hii.c:231:
> + ret = add_strings_package(hii,
> + (struct efi_hii_strings_package *)package);
I've noticed this warning as well as another type of warning, such as
CHECK: Lines should not end with a '('
#186: FILE: include/efi_api.h:832:
+ efi_status_t(EFIAPI *new_package_list)(
CHECK: spaces preferred around that '*' (ctx:WxV)
#186: FILE: include/efi_api.h:832:
+ efi_status_t(EFIAPI *new_package_list)(
Those are quite difficult to fix without sacrificing readability
or introducing another warning.
If you have any solution, please let me know.
| case EFI_HII_PACKAGE_STRINGS:
| struct efi_hii_strings_package *strings_package;
|
| strings_package = (struct efi_hii_strings_package *)package);
| ret = add_strings_package(hii, strings_package);
|
This kinda fix is a non-sense, I believe.
-Takahiro Akashi
> Please, adjust the alignment.
>
> Best regards
>
> Heinrich
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
