On Wed, Oct 31, 2018 at 7:35 AM Jagan Teki <ja...@amarulasolutions.com> wrote: > > On Sun, Oct 7, 2018 at 12:46 PM Simon Goldschmidt > <simon.k.r.goldschm...@gmail.com> wrote: > > > > The table of spi flash chips 'spi_flash_ids' currently > > includes chip names. The only usage of these is to > > print the name when the chip is probed. > > > > Since this message is not shown in SPL, we can remove > > the names from the SPL binary. > > > > Removing the chip names saves ~890 Byte from the SPL > > binary in my configuration (socfpga_socrates_defconfig, > > MACRONIX, SPANSION and STMICRO enabled). > > I'm not still quite happy with this change, other than reducing the > size which introduces many ifdef's what would you benefits with this > 890bytes? do you have any room to add any key features in SPL?
Well, SPL is always tight, isn't it? Currently, I have ~7.5 kB free on my socfpga gen5 board. And to get the features required by management, I will have to add suppport for loading U-Boot from a FIT image and checking its signature. Because of that, I figured saving RAM in SPL would be good. I don't know my required features fit in after applying this patch, though. But if you don't like it, feel free to drop it. I don't have an immediate need to apply this. Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
