On Thu, Oct 25, 2018 at 2:46 PM Poonam Aggrwal <poonam.aggr...@nxp.com> wrote: > > Hello Bin, > > > > -----Original Message----- > > From: Bin Meng [mailto:bmeng...@gmail.com] > > Sent: Monday, October 22, 2018 9:41 AM > > To: Poonam Aggrwal <poonam.aggr...@nxp.com> > > Cc: York Sun <york....@nxp.com>; U-Boot Mailing List <u-boot@lists.denx.de> > > Subject: Re: [PATCH 1/2] powerpc: t1040: Correct RCW MAC2_GMII_SEL value > > > > Hi Poonam, > > > > On Mon, Oct 22, 2018 at 11:43 AM Poonam Aggrwal > > <poonam.aggr...@nxp.com> wrote: > > > > > > > > > > > > > -----Original Message----- > > > > From: Bin Meng [mailto:bmeng...@gmail.com] > > > > Sent: Monday, October 22, 2018 7:41 AM > > > > To: York Sun <york....@nxp.com> > > > > Cc: Poonam Aggrwal <poonam.aggr...@nxp.com>; U-Boot Mailing List <u- > > > > b...@lists.denx.de> > > > > Subject: Re: [PATCH 1/2] powerpc: t1040: Correct RCW MAC2_GMII_SEL > > > > value > > > > > > > > On Mon, Oct 15, 2018 at 1:21 PM Bin Meng <bmeng...@gmail.com> wrote: > > > > > > > > > > On Mon, Oct 8, 2018 at 11:07 PM York Sun <york....@nxp.com> wrote: > > > > > > > > > > > > On 10/08/2018 06:51 AM, Bin Meng wrote: > > > > > > > Per T1040RM (Rev. 1, 08/2015), the value of > > > > > > > FSL_CORENET_RCWSR13_MAC2_GMII_SEL_ENET_PORT is wrong and > > > > should be > > > > > > > 0x00000080 (bit 440 in the RCW). > > > > > > > > > > > > > > Signed-off-by: Bin Meng <bmeng...@gmail.com> > > > > > > > --- > > > > > > > > > > > > > > > > > > Poonam, > > > > > > > > > > > > Please review and confirm on T1040. Thanks. > > > > > > > > > > > > > > > > Ping ? > > > > > > > > Ping ? > > > Apologies Bin, York for such late response.... > > > The patch looks correct, the value of > > > FSL_CORENET_RCWSR13_MAC2_GMII_SEL_ENET_PORT should be 0x80 > > indeed, I would suggest that I test it once that DTSEC2 RGMII works with > > this > > change, because I see more changes which could be required in > > drivers/fm/t1040.c...seems a goof up there as well. > > > > > > > t1040.c changes is patch [2/2], see > > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.de > > nx.de%2Fpipermail%2Fu-boot%2F2018- > > October%2F343499.html&data=02%7C01%7Cpoonam.aggrwal%40nxp.co > > m%7Ce1f6945b731f464c4f6008d637d47259%7C686ea1d3bc2b4c6fa92cd99c5c > > 301635%7C0%7C0%7C636757782923893367&sdata=INveAWT0s6WsppKP > > TqCFYo50BH4sekDf9HFAscXxMw8%3D&reserved=0 > This patch is correct, thanks for the fix.. > Acked > > Both the patches are good.. >
Thanks Poonam! York, I believe these 2 patches need be included in the v2018.11 release. Regards, Bin _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
