Hi Simon, On Thu, Sep 27, 2018 at 9:42 PM Simon Glass <s...@chromium.org> wrote: > > On 23 September 2018 at 06:42, Bin Meng <bmeng...@gmail.com> wrote: > > From: Tuomas Tynkkynen <tuomas.tynkky...@iki.fi> > > > > This adds support for managing virtual queue/ring, the channel > > for high performance I/O between host and guest. > > > > Signed-off-by: Tuomas Tynkkynen <tuomas.tynkky...@iki.fi> > > Signed-off-by: Bin Meng <bmeng...@gmail.com> > > --- > > > > drivers/virtio/Makefile | 2 +- > > drivers/virtio/virtio_ring.c | 356 > > +++++++++++++++++++++++++++++++++++++++++++ > > include/virtio_ring.h | 320 ++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 677 insertions(+), 1 deletion(-) > > create mode 100644 drivers/virtio/virtio_ring.c > > create mode 100644 include/virtio_ring.h > > Seems like vring_create_virtqueue() should return an error code rather > than a pointer?
I think NULL as a pointer can be a sign for the error. > > Reviewed-by: Simon Glass <s...@chromium.org> Regards, Bin _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot