Vipin KUMAR wrote: > On 3/29/2010 3:21 AM, Tom wrote: >> Vipin KUMAR wrote: >>> SMI driver fails because of low timeout values. Increasing the erase >>> and write >>> timeouts to 3 seconds >> This is a huge timeout change. >> 2ms to 3000ms. >> If something goes wrong, it will seem like the board is hung. >> Is this ok? >> > > 2ms timeout itself was a mistake. 3 sec is OK. Offcourse, 3 secs are > required only when something goes wrong
OK > <snip> >>> + } while (timeout--); >> This changes the function to wait at least 1ms even if timeout == 0. >> Why was the original logic changed? >> > > Earlier a value of 2 was reading the status register only once. This I > felt is more appropriate since the status register is read every ms and > at least once. OK Tom _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
