On 09/07/2018 08:24 AM, Ley Foon Tan wrote:
> Change to use managed resource function devm_kcalloc(),
> so it will auto free memory when driver is removed.
> 
> Signed-off-by: Ley Foon Tan <ley.foon....@intel.com>
> 
> ---
> v2:
> - Remove free() function.
> ---
>  drivers/gpio/dwapb_gpio.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpio/dwapb_gpio.c b/drivers/gpio/dwapb_gpio.c
> index 0f6574d..6f9d17d 100644
> --- a/drivers/gpio/dwapb_gpio.c
> +++ b/drivers/gpio/dwapb_gpio.c
> @@ -171,8 +171,7 @@ static int gpio_dwapb_bind(struct udevice *dev)
>               if (!fdtdec_get_bool(blob, node, "gpio-controller"))
>                       continue;
>  
> -             plat = NULL;
> -             plat = calloc(1, sizeof(*plat));
> +             plat = devm_kcalloc(dev, 1, sizeof(*plat), GFP_KERNEL);
>               if (!plat)
>                       return -ENOMEM;
>  
> @@ -196,7 +195,6 @@ static int gpio_dwapb_bind(struct udevice *dev)
>       return 0;
>  
>  err:
> -     free(plat);
>       return ret;

Well, this becomes return ret, right ? ;-)

>  }
>  
> 


-- 
Best regards,
Marek Vasut
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Reply via email to