On Tue, Aug 28, 2018 at 6:50 PM Jagdish Gediya <jagdish.ged...@nxp.com> wrote:
>
> Hi Bin,
>
> > -----Original Message-----
> > From: Bin Meng <bmeng...@gmail.com>
> > Sent: Tuesday, August 28, 2018 2:46 PM
> > To: Jagdish Gediya <jagdish.ged...@nxp.com>
> > Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Prabhakar Kushwaha
> > <prabhakar.kushw...@nxp.com>; York Sun <york....@nxp.com>; Poonam
> > Aggrwal <poonam.aggr...@nxp.com>; Simon Glass <s...@chromium.org>;
> > Tom Rini <tr...@konsulko.com>
> > Subject: Re: [PATCH v2 1/8] powerpc/dts: Define '_end' symbol in mpc85xx u-
> > boot lds files
> >
> > On Tue, Aug 28, 2018 at 11:53 AM Jagdish Gediya <jagdish.ged...@nxp.com>
> > wrote:
> > >
> > > 'board_fdt_blob_setup' function sets up fdt blob at '&_end' so define
> > > '_end' symbol in mpc85xx lds files.
> > >
> > > Signed-off-by: Jagdish Gediya <jagdish.ged...@nxp.com>
> > > ---
> > > Changes for v2:
> > >         - Defined '_end' symbol in lds file instead of defining new
> > >           'board_fdt_blob_setup' function using existing '_init_end' 
> > > symbol.
> > >
> > >  arch/powerpc/cpu/mpc85xx/u-boot-nand.lds | 1 +
> > >  arch/powerpc/cpu/mpc85xx/u-boot.lds      | 1 +
> > >  2 files changed, 2 insertions(+)
> > >
> >
> > This only updates 2 lds files. Can you update all mpc85xx lds files so that 
> > they
> > are consistent?
>
> Remaining are spl lds files and I think '_end' symbol is not needed there.

But if you look at other targets, the spl version lds has the _end
symbol. Adding _end there does not cause any problem, no?

Regards,
Bin
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Reply via email to