Re: [U-Boot] [PATCH 3/3] fsl_esdhc: Only modify the field we are changing in WML

[Kumar Gala]

On Mar 20, 2010, at 12:59 PM, Stefano Babic wrote:

> Kumar Gala wrote:
>> From: Roy Zang <tie-fei.z...@freescale.com>
>> 
>> When we set the read or write watermark in WML we should maintain the
>> rest of the register as is, rather than using some hard coded value.
>> 
>> Signed-off-by: Roy Zang <tie-fei.z...@freescale.com>
>> Signed-off-by: Kumar Gala <ga...@kernel.crashing.org>
>> ---
>> * This patch supercededs (fsl_esdhc: Only modify WML[WR] field)
> 
> Hi,
> 
>> +            esdhc_clrsetbits32(&regs->wml, WML_WR_WML_MASK, wml_value << 
>> 16);
> 
> Line too long.
> 
> Tested successfully on mx51evk.
> 
> Acked-by: Stefano Babic <sba...@denx.de>
> 
> Regards,
> Stefano

Thanks, will fix the line length in my git tree commit.

- k
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot