On Friday 24 August 2018 07:41 PM, Tom Rini wrote: > On Tue, Aug 21, 2018 at 08:01:39PM +0530, Lokesh Vutla wrote: > >> Texas Instrument's System Control Interface (TI SCI) message protocol is >> used in Texas Instrument's System on Chip (SoC) such as those in the K3 >> family AM654 SoC to communicate between various compute processors with >> a central system controller entity. >> >> The TI SCI message protocol provides support for management of various >> hardware entities within the SoC. Add support driver to allow >> communication with system controller entity within the SoC using the >> mailbox client. >> >> This is mostly derived from the TI SCI driver in Linux located at >> drivers/firmware/ti_sci.c. > > Since K3 support for the kernel is also being posted now, please make > sure any feedback to ti_sci there for K3 is worked in here as well when > applicable, thanks!
ti_sci linux driver is already upstreamed and this is a port of the upstream driver. > >> >> Signed-off-by: Lokesh Vutla <lokeshvu...@ti.com> >> Signed-off-by: Nishanth Menon <n...@ti.com> >> Signed-off-by: Andreas Dannenberg <dannenb...@ti.com> > > Content wise, seems fine: > > Reviewed-by: Tom Rini <tr...@konsulko.com> > > [snip] >> +++ b/include/linux/soc/ti/ti_sci_protocol.h >> @@ -0,0 +1,69 @@ >> +/* >> + * Texas Instruments System Control Interface Protocol >> + * Based on include/linux/soc/ti/ti_sci_protocol.h from Linux. >> + * >> + * Copyright (C) 2018 Texas Instruments Incorporated - http://www.ti.com/ >> + * Nishanth Menon >> + * Lokesh Vutla <lokeshvu...@ti.com> >> + * >> + * SPDX-License-Identifier: GPL-2.0+ >> + */ > > Since you've got one here, please run checkpatch.pl on the whole series > to check for other places where the SDPX header isn't in the right spot > (and of course other style/etc problems checkpatch complains about). > ahh my bad. Will fix it everywhere. Thanks and regards, Lokesh _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
