On 08/23/2018 23:20 PM, York Sun wrote: >> - if (ft_fixup_port(blob, &fm_info[i], "fsl,fman-tgec")) >> + if (ft_fixup_port(blob, &fm_info[i], "fsl,fman-tgec") && >> + ft_fixup_port(blob, &fm_info[i], "fsl,fman-xgec"))
>Is this logic correct? You want success return from fixing up _both_ fman-tgec >and fman-xgec before fixup fman-10-mac? fman-10-mac, tgec and xgec is the different version compatible, it used fman-10-mac at the first time, then modified to tgec and now xgec. If it fix up successfully with fman-10-mac, it will return 0, and doesn't fix up for the other two compatible. If failed with fman-tgec, then to fix up for fsl,fman-xgec, if success, return 0 and doesn't fix up for fman-10-mac. BR Qiang Zhao _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
