Hi, On Mon, Aug 20, 2018 at 10:02:31PM +0530, Jagan Teki wrote: > - glue->ccm = (struct sunxi_ccm_reg *)SUNXI_CCM_BASE; > - if (IS_ERR(glue->ccm)) > - return PTR_ERR(glue->ccm); > + if (glue->cfg->has_reset) > + test_and_set_bit(SUNXI_MUSB_FL_HAS_RESET, &glue->flags);
I'm not sure why the flag is needed here. It's completely redundant with the boolean you're testing to set that flag. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
