On Sun, Aug 05, 2018 at 06:53:07PM +0200, Miquel Raynal wrote: > The recv variable in sandbox_tpm2_fill_buf() is a pointer on a pointer > of a char array. It means accessing *recv is the char array pointer > itself while **recv is the first character of that array. There is no > need for such indirection here, so simplify the code. > > Simplifying things will make the last assignment right: "*recv = NULL" > is now correct. The issue has been found by the following Coverity > Scan report: > > CID 183371: Incorrect expression (UNUSED_VALUE) > Assigning value "4UL" to "*recv" here, but that stored value is > overwritten before it can be used. > 232 *recv += sizeof(rc); > 233 > 234 /* Add trailing \0 */ > 235 *recv = NULL; > > While at simplifying things, use '\0' instead of NULL when adding an > empty char at the end of the buffer. > > Reported-by: Tom Rini <tr...@konsulko.com> > Signed-off-by: Miquel Raynal <miquel.ray...@bootlin.com> > Reviewed-by: Simon Glass <s...@chromium.org>
Applied to u-boot/master, thanks! -- Tom
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
