Hi Peng, On Fri, 10 Aug 2018 02:30:09 +0000 Peng Fan peng....@nxp.com wrote: ... > > Thanks for working on this! I think we should rename this driver to imx-mu > > and > > unify it, so that it can be used on i.MX7 and i.MX6SX, if needed. > > > Thanks for reviewing the patcset. Communicating with SCU needs > dedicated mu designed for SCU, and the scfw requires all the 4 channels > being used. It will introduce too much complexity to develop a generic mu > driver support generic mu and scu mu. I would not do that.
OK. ... > > > + gd->arch.scu_dev = dev; > > > > Can we avoid using the dev pointer in global data? > > I could not find a better solution to make other components could > easily refer the scu dev. Do you have any suggestions? No. I think we will have to stick with the scu_dev in global data, now I see that it is needed just after relocation and before initr_dm(), so we can't get it just after relocation via dm functions. > Do you have time to review the remaining patches in the patchset? I'm working on ENET and I2C/USB/LVDS support for i.MX8QXP MEK based on this patch series and will try to review remaining patches over the weekend. Thanks, Anatolij _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
