On Fri, Aug 10, 2018 at 2:54 PM Anand Moon <linux.am...@gmail.com> wrote:
> set the value of MEMORY_BANKS_MAX to 8.
> Odroid-XU4 fails to boot with following message
>
> fdt_fixup_memory_banks: num banks 8 exceeds hardcoded limit 4.
> Recompile with higher MEMORY_BANKS_MAX?
> ERROR: arch-specific fdt fixup failed
> - must RESET the board to recover.
>
> Fixes: commit 2a1f4f1758b5 (Revert "fdt_support: Use CONFIG_NR_DRAM_BANKS
> if defined")
>
> CC: Ramon Fried <ramon.fr...@gmail.com>
> CC: Simon Glass <s...@chromium.org>
> Signed-off-by: Anand Moon <linux.am...@gmail.com>
> ---
> common/fdt_support.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/fdt_support.c b/common/fdt_support.c
> index 34d2bd59c4..ad87f31ab3 100644
> --- a/common/fdt_support.c
> +++ b/common/fdt_support.c
> @@ -409,7 +409,7 @@ static int fdt_pack_reg(const void *fdt, void *buf,
> u64 *address, u64 *size,
> return p - (char *)buf;
> }
>
> I think it's better to check if MEMORY_BANKS was defined and only if not
to define it to 4.
Then users can define MEMORY_BANKS at include/configs/....h
Simon, what do you say ?
-#define MEMORY_BANKS_MAX 4
> +#define MEMORY_BANKS_MAX 8
> int fdt_fixup_memory_banks(void *blob, u64 start[], u64 size[], int banks)
> {
> int err, nodeoffset;
> --
> 2.17.1
>
>
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
