Hi York, > -----Original Message----- > From: York Sun > Sent: Friday, August 10, 2018 03:46 > To: Ran Wang <ran.wan...@nxp.com> > Cc: u-boot@lists.denx.de > Subject: Re: [PATCH v3 2/2] armv8: layerscape: move ns_dev[] define from h > to c file. > > On 08/03/2018 12:56 AM, Ran Wang wrote: > > Since more c files will include ns_access.h, this move will fix some > > compiling warnings and make it sense. > > > > Signed-off-by: Ran Wang <ran.wan...@nxp.com> > > --- > > Change in v3: > > - New file > > > > .../include/asm/arch-fsl-layerscape/ns_access.h | 80 > > ---------------------- > > board/freescale/common/ns_access.c | 80 > ++++++++++++++++++++++ > > 2 files changed, 80 insertions(+), 80 deletions(-) > > > > Two issues with this patch. First this patch should be in front of your patch > #1. Otherwise you patch #1 has this compiling warning > > warning: ?ns_dev? defined but not used [-Wunused-variable] OK, will change the patch order
> Second issue is for ls1021a. You will see compiling failure. Yes, I just located the issue, will fix it in next version, thanks for point out Ran > > York _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
