Re: [U-Boot] [PATCH 0/2] Ethernet name length changes

[Pankaj Bansal]

> -----Original Message-----
> From: Joe Hershberger [mailto:joe.hershber...@ni.com]
> Sent: Thursday, August 2, 2018 10:15 PM
> To: Pankaj Bansal <pankaj.ban...@nxp.com>
> Cc: u-boot <u-boot@lists.denx.de>; Joe Hershberger
> <joe.hershber...@ni.com>; Varun Sethi <v.se...@nxp.com>
> Subject: Re: [U-Boot] [PATCH 0/2] Ethernet name length changes
> 
> On Thu, Aug 2, 2018 at 6:01 AM, Pankaj Bansal <pankaj.ban...@nxp.com>
> wrote:
> > The ethernet name should be within the ETH_NAME_LEN, as this is the
> > buffer space allocated to ethernet name.
> >
> > Otherwise, this causes buffer overflow.
> >
> > At the same time the 16 char ethernet name size is inadequate to hold
> > the name of ethernet "DPMAC17@rgmii-id", which is a valid name in
> > upcoming LX2160AQDS/LX2160ARDB boards.
> 
> Can you just shorten the name? This is a shared constant with Linux, so
> while we could change it, I'd prefer not to.

Ok. Then you can just accept the first patch and leave the second one.
With first patch we limit the ethernet name to ETH_NAME_LEN.

> 
> > These patches try to solve the above two issues:
> > 1. first patch honors the limit imposed by ETH_NAME_LEN on ethernet
> > name 2. second patch increases this limit to accommodate the
> requirements of
> >    LX2160AQDS/LX2160ARDB
> >
> > Cc: Varun Sethi <v.se...@nxp.com>
> >
> > Pankaj Bansal (2):
> >   fsl/mc: Limit the ethernet name to ETH_NAME_LEN
> >   net: Increase ethernet name string size to 20 chars
> >
> >  drivers/net/fsl-mc/mc.c           | 6 +++---
> >  drivers/net/ldpaa_eth/ldpaa_eth.c | 4 ++--
> >  include/net.h                     | 2 +-
> >  3 files changed, 6 insertions(+), 6 deletions(-)
> >
> > --
> > 2.17.1
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot@lists.denx.de
> >
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flis
> > ts.denx.de%2Flistinfo%2Fu-
> boot&amp;data=02%7C01%7Cpankaj.bansal%40nxp.
> >
> com%7C11b8c79a3833492ed17608d5f8976b50%7C686ea1d3bc2b4c6fa9
> 2cd99c5c301
> >
> 635%7C0%7C0%7C636688251592976394&amp;sdata=gyGRsE%2B8MSXA
> U7IiycV7CtWGc
> > yabeUuBiTf9HJbVPQU%3D&amp;reserved=0
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot