On 31 July 2018 at 04:01, Mario Six <mario....@gdsys.cc> wrote: > Add a driver for gdsys IHS (Integrated Hardware Systems) FPGAs, which > supports initialization of the FPGA, as well as information gathering. > > Signed-off-by: Mario Six <mario....@gdsys.cc> > --- > > v2 -> v3: > * Fixed style violations > * Added full documentation > * Extracted some magic numbers to constants > * Removed unnecessary includes > * Extracted wait_for_fpga_done > * Improved error handling and reporting > * Added device-tree-binding files > * Improved Kconfig entry > > v1 -> v2: > New in v2 > > --- > .../devicetree/bindings/misc/gdsys,iocon_fpga.txt | 19 + > .../devicetree/bindings/misc/gdsys,iocpu_fpga.txt | 19 + > drivers/misc/Kconfig | 9 + > drivers/misc/Makefile | 1 + > drivers/misc/ihs_fpga.c | 867 > +++++++++++++++++++++ > drivers/misc/ihs_fpga.h | 49 ++ > 6 files changed, 964 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/misc/gdsys,iocon_fpga.txt > create mode 100644 > Documentation/devicetree/bindings/misc/gdsys,iocpu_fpga.txt > create mode 100644 drivers/misc/ihs_fpga.c > create mode 100644 drivers/misc/ihs_fpga.h
Reviewed-by: Simon Glass <s...@chromium.org> My only nit is that I prefer 'ret' for the return value instead of 'rc' or 'res', for consistency with driver model. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
