On Wed, Jul 25, 2018 at 01:02:31AM +0100, Andre Przywara wrote: > "default" lines in Kconfig are processed in order, the first hit will > stop considering subsequent lines. In the case of the DRAM_ODT_EN symbol > that means that everything following the first two lines will never be > checked: > ------------ > config DRAM_ODT_EN > bool "sunxi dram odt enable" > default n if !MACH_SUN8I_A23 > default y if MACH_SUN8I_A23 > default y if MACH_SUN8I_R40 > default y if MACH_SUN50I > ------------ > > Assuming that the "default y" for the A64 and the R40 were a deliberate > choice, fix the Kconfig stanza to take this into account. > Also remove the now redundant lines from the respective defconfigs. > > Signed-off-by: Andre Przywara <andre.przyw...@arm.com> > --- > Hi, > > I would be grateful if people could test this and find out whether > enabling ODT works reliably. > > Thanks! > Andre. > > arch/arm/mach-sunxi/Kconfig | 2 +- > configs/Bananapi_M2_Ultra_defconfig | 1 - > configs/amarula_a64_relic_defconfig | 1 - > configs/bananapi_m2_berry_defconfig | 1 - > configs/sopine_baseboard_defconfig | 1 - > 5 files changed, 1 insertion(+), 5 deletions(-) > > diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig > index 678e33dd40..7ff0347e20 100644 > --- a/arch/arm/mach-sunxi/Kconfig > +++ b/arch/arm/mach-sunxi/Kconfig > @@ -405,10 +405,10 @@ config DRAM_ZQ > > config DRAM_ODT_EN > bool "sunxi dram odt enable" > - default n if !MACH_SUN8I_A23 > default y if MACH_SUN8I_A23 > default y if MACH_SUN8I_R40 > default y if MACH_SUN50I > + default n
I think this is the default's default, so there's no need to set it explicitly. Otherwise, Acked-by: Maxime Ripard <maxime.rip...@bootlin.com> Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
