> Op 17 jul. 2018, om 16:06 heeft Peter Robinson <pbrobin...@gmail.com> het
> volgende geschreven:
>
> On Tue, Jul 17, 2018 at 3:01 PM, Koen Kooi <k...@dominion.thruhere.net> wrote:
>>
[..]
>> --- a/board/ti/am335x/mux.c
>> +++ b/board/ti/am335x/mux.c
>> @@ -381,6 +381,13 @@ void enable_board_pin_mux(void)
>> configure_module_pin_mux(mmc0_pin_mux_sk_evm);
>> } else if (board_is_bone_lt()) {
>> /* Beaglebone LT pinmux */
>
> I think this comment is duplicated below so this one should be
> updated/dropped?
What do you think about moving it below the if statement:
>> + if (board_is_bben()) {
>> + /* SanCloud Beaglebone LT Enhanced pinmux */
>> + configure_module_pin_mux(rgmii1_pin_mux);
>> + } else {
>> + /* Beaglebone LT pinmux */
>> + configure_module_pin_mux(mii1_pin_mux);
>> + }
X marks the spot
>> configure_module_pin_mux(mii1_pin_mux);
>> configure_module_pin_mux(mmc0_pin_mux);
That would make it clear that it’s the LT pinmux again.
I’m fine with dropping it as well.
regards,
Koen
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
