Hi Jagan and co, On Mon, May 28, 2018 at 04:48:33PM +0530, Jagan Teki wrote: > Allwinner USB PHY handling can be done through driver-model > generic-phy so add the generic-phy ops to relevant places on host and > musb sunxi driver and enable them in respective SOC's.
This patch series breaks USB support on the A10 Cubieboard, with Cubieboard_defconfig. I'm booting off an SD card, with a USB storage device plugged into the lower of the two USB ports. With aa29b11b3f ("Add a sunxi specific function for setting squelch-detect") and older versions, everything is OK and u-boot can see the USB device: > starting USB... > USB0: USB EHCI 1.00 > USB1: USB OHCI 1.0 > USB2: USB EHCI 1.00 > USB3: USB OHCI 1.0 > scanning bus 0 for devices... 2 USB Device(s) found > scanning bus 2 for devices... 1 USB Device(s) found > scanning usb for storage devices... 1 Storage Device(s) found With dd3228170a ("Switch to use generic-phy"), I get: > starting USB... > USB0: failed to get usb@01c14000 usb PHY > probe failed, error -16 > USB1: failed to get usb@01c14400 usb PHY > probe failed, error -16 > USB2: failed to get usb@01c1c000 usb PHY > probe failed, error -16 > USB3: failed to get usb@01c1c400 usb PHY > probe failed, error -16 > USB error: all controllers failed lowlevel init And with f5871a66fd ("Drop legacy usb_phy.c") and later versions including current master, I get: > starting USB... > USB0: USB EHCI 0.00 > USB1: USB OHCI 0.0 > USB2: USB EHCI 1.00 > USB3: USB OHCI 1.0 > scanning bus 0 for devices... 1 USB Device(s) found > scanning bus 2 for devices... 1 USB Device(s) found > scanning usb for storage devices... 0 Storage Device(s) found Note the 0.00 revision numbers in the EHCI/OHCI lowlevel init output there. Any ideas about what might have gone wrong? Let me know if you need any more information... Cheers, -- Adam Sampson <a...@offog.org> <http://offog.org/> _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot