Hi Joe, Simon, > -----Original Message----- > From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon Glass > Sent: 2018年6月13日 9:26 > To: Joe Hershberger <joe.hershber...@ni.com> > Cc: Peng Fan <peng....@nxp.com>; Stefano Babic <sba...@denx.de>; Fabio > Estevam <fabio.este...@nxp.com>; u-boot <u-boot@lists.denx.de> > Subject: Re: [U-Boot] [PATCH 28/41] net: fec_mxc: Add the init_clk_fec > function > > Hi, > > On 12 June 2018 at 12:27, Joe Hershberger <joe.hershber...@ni.com> wrote: > > > > Hi Peng, > > > > On Mon, May 28, 2018 at 7:25 AM, Peng Fan <peng....@nxp.com> wrote: > > > From: Ye Li <ye...@nxp.com> > > > > > > When the power domain driver is enabled, we need to enable clocks > > > after power domain on. So the clock settings can't set in > > > board_init, needs to set them when the device is probed. Add this > > > weak function in driver, that SoC codes can implement the clock settings. > > > > Can you not use clock infrastructure in DM to handle this. We don't > > really want these direct calls out of drivers like this. Simon? > > > > Yes that is definitely bad. > > Probably the easiest option is to add a clock driver.
I'll give a try to add a clock DM driver. Thanks, Peng. > > Regards, > Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
