Hi Frans,
> fix pointer dereferencing
> if the size is .b and .w an 8 or 16 bit access is done.
>
> Signed-off-by: Frans Meulenbroeks <fransmeulenbro...@gmail.com>
> ---
> common/cmd_itest.c | 9 ++++++---
> 1 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/common/cmd_itest.c b/common/cmd_itest.c
> index 5b301bf..6e1079c 100644
> --- a/common/cmd_itest.c
> +++ b/common/cmd_itest.c
> @@ -66,16 +66,19 @@ op_tbl_t op_table [] = {
>
> static long evalexp(char *s, int w)
> {
> - long l, *p;
> + long l = 0
> + long *p;
It takes chuzpe to send patches that do not even compile ;) Who ate the
';'?
>
> /* if the parameter starts with a * then assume is a pointer to the
> value we want */
> if (s[0] == '*') {
> p = (long *)simple_strtoul(&s[1], NULL, 16);
> - l = *p;
> + switch (w) {
> + case 1: return((long)(*(unsigned char *)p));
> + case 2: return((long)(*(unsigned short *)p));
> + case 4: return(*p);
The switch statement needs to be closed also.
> } else {
> l = simple_strtoul(s, NULL, 16);
> }
> -
> return (l & ((1 << (w * 8)) - 1));
> }
Once you fix the syntax errors -
Acked-by: Detlev Zundel <d...@denx.de>
Cheers
Detlev
--
"Our enemies are innovative and resourceful, and so are we. They
never stop thinking about new ways to harm our country and our people,
and neither do we."
-- George W. Bush during a defense bill ceremony on 5. Aug 2004
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
