[U-Boot] [RFC] gpio: omap_gpio: Convert to auto-alloc feature when DT is supported

[Adam Ford]

The omap_gpio driver has a TODO that says when every board is converted
to DM and DT, the omap_gpio_bind can stop using calloc and switch
to auto-alloc.

This patch converts this driver to auto-calloc when DT is enabled.

Signed-off-by: Adam Ford <aford...@gmail.com>

diff --git a/drivers/gpio/omap_gpio.c b/drivers/gpio/omap_gpio.c
index d128f942a0..4d54df284d 100644
--- a/drivers/gpio/omap_gpio.c
+++ b/drivers/gpio/omap_gpio.c
@@ -296,6 +296,7 @@ static int omap_gpio_probe(struct udevice *dev)
        return 0;
 }
 
+#if !CONFIG_IS_ENABLED(OF_CONTROL)
 static int omap_gpio_bind(struct udevice *dev)
 {
        struct omap_gpio_platdata *plat = dev_get_platdata(dev);
@@ -328,6 +329,7 @@ static int omap_gpio_bind(struct udevice *dev)
 
        return 0;
 }
+#endif
 
 static const struct udevice_id omap_gpio_ids[] = {
        { .compatible = "ti,omap3-gpio" },
@@ -336,12 +338,33 @@ static const struct udevice_id omap_gpio_ids[] = {
        { }
 };
 
+#if CONFIG_IS_ENABLED(OF_CONTROL)
+static int omap_gpio_ofdata_to_platdata(struct udevice *dev)
+{
+       struct omap_gpio_platdata *plat = dev_get_platdata(dev);
+       fdt_addr_t addr;
+
+       addr = devfdt_get_addr(dev);
+       if (addr == FDT_ADDR_T_NONE)
+               return -EINVAL;
+
+       plat->base = addr;
+       return 0;
+}
+#endif
+
 U_BOOT_DRIVER(gpio_omap) = {
        .name   = "gpio_omap",
        .id     = UCLASS_GPIO,
+#if CONFIG_IS_ENABLED(OF_CONTROL)
+       .ofdata_to_platdata = of_match_ptr(omap_gpio_ofdata_to_platdata),
+       .bind   = dm_scan_fdt_dev,
+       .platdata_auto_alloc_size = sizeof(struct omap_gpio_platdata),
+#else
+       .bind   = omap_gpio_bind,
+#endif
        .ops    = &gpio_omap_ops,
        .of_match = omap_gpio_ids,
-       .bind   = omap_gpio_bind,
        .probe  = omap_gpio_probe,
        .priv_auto_alloc_size = sizeof(struct gpio_bank),
        .flags = DM_FLAG_PRE_RELOC,
-- 
2.17.1

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot