On 06/04/2018 01:37 PM, Michal Simek wrote:
> Use enum command_ret_t types in cmd_process_error().
> Also handle USAGE failure separately.
>
> Signed-off-by: Michal Simek <michal.si...@xilinx.com>
> ---
>
> common/command.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/common/command.c b/common/command.c
> index 52d47c133c3c..2433a89e0a8e 100644
> --- a/common/command.c
> +++ b/common/command.c
> @@ -547,10 +547,13 @@ enum command_ret_t cmd_process(int flag, int argc, char
> * const argv[],
>
> int cmd_process_error(cmd_tbl_t *cmdtp, int err)
> {
> + if (err == CMD_RET_USAGE)
> + return CMD_RET_USAGE;
This changes the return value of the function (-1 instead of 1). So you
would have to change the comments in include/command.h.
Your commit message gives no clue why you do not want to return
CMD_RET_FAILURE here and which consequences this has especially in scripts.
Best regards
Heinrich
> +
> if (err) {
> printf("Command '%s' failed: Error %d\n", cmdtp->name, err);
> - return 1;
> + return CMD_RET_FAILURE;
> }
>
> - return 0;
> + return CMD_RET_SUCCESS;
> }
>
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
