Hi Simon, On Wed, May 23, 2018 at 6:33 PM, Simon Glass <s...@chromium.org> wrote: > Hi Mario, > > On 23 May 2018 at 06:09, Mario Six <mario....@gdsys.cc> wrote: >> Add sandbox driver and tests for the new OSD uclass. >> >> Signed-off-by: Mario Six <mario....@gdsys.cc> >> >> --- >> >> v1 -> v2: >> New in v2 >> >> --- >> arch/sandbox/dts/test.dts | 4 + >> configs/sandbox64_defconfig | 3 + >> configs/sandbox_defconfig | 3 + >> configs/sandbox_flattree_defconfig | 3 + >> configs/sandbox_noblk_defconfig | 3 + >> configs/sandbox_spl_defconfig | 3 + >> drivers/video/Kconfig | 6 ++ >> drivers/video/Makefile | 1 + >> drivers/video/sandbox_osd.c | 157 ++++++++++++++++++++++++++++ >> drivers/video/sandbox_osd.h | 14 +++ >> drivers/video/video_osd-uclass.c | 9 ++ >> include/video_osd.h | 7 ++ >> test/dm/Makefile | 1 + >> test/dm/osd.c | 208 >> +++++++++++++++++++++++++++++++++++++ >> 14 files changed, 422 insertions(+) >> create mode 100644 drivers/video/sandbox_osd.c >> create mode 100644 drivers/video/sandbox_osd.h >> create mode 100644 test/dm/osd.c > > This looks good. But you can't add a new get_mem() operation just for sandbox. > > Instead, how about a back-door function that allows sandbox to get its > information. You can call it sandbox_video_osd_get_mem(), for example, > and just directly call it from you test code and implement it in your > driver. > > There are some functions like this in arch/sandbox/include/asm/test.h >
OK, I will do that for v3. > Regards, > Simon > Best regards, Mario _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
