I'm abandoning these, as I see that there's already a patch series that
covers this. (sunxi: sync H3, H5, A64 DTs from mainline Linux)
Jonathan Kollasch
On Fri, May 18, 2018 at 10:18:37AM +0200, Maxime Ripard wrote:
> Hi,
>
> On Thu, May 17, 2018 at 04:03:33PM -0500, Jonathan A. Kollasch wrote:
> > Signed-off-by: Jonathan A. Kollasch <jakll...@kollasch.net>
> > ---
> >
> > arch/arm/dts/sun50i-h5-nanopi-neo-plus2.dts | 15 +++++++++++++++
> > 1 file changed, 15 insertions(+)
> >
> > diff --git a/arch/arm/dts/sun50i-h5-nanopi-neo-plus2.dts
> > b/arch/arm/dts/sun50i-h5-nanopi-neo-plus2.dts
> > index f1406c224b..1dde153669 100644
> > --- a/arch/arm/dts/sun50i-h5-nanopi-neo-plus2.dts
> > +++ b/arch/arm/dts/sun50i-h5-nanopi-neo-plus2.dts
> > @@ -104,3 +104,18 @@
> > &usbphy {
> > status = "okay";
> > };
> > +
> > +&emac {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&emac_rgmii_pins>;
> > + phy-mode = "rgmii";
> > + phy-handle = <&ext_rgmii_phy>;
> > + status = "okay";
> > +};
> > +
> > +&external_mdio {
> > + ext_rgmii_phy: ethernet-phy@7 {
> > + compatible = "ethernet-phy-ieee802.3-c22";
> > + reg = <7>;
> > + };
> > +};
>
> We usually share our DT with Linux, and the node is already described
> there, so we should just sync the DT with the Linux one instead.
>
> Please provide the Linux commit ID you used to sync in your next
> iteration too.
>
> Thanks!
> Maxime
>
> --
> Maxime Ripard, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com
On Fri, May 18, 2018 at 03:24:22PM +0200, Antony Antony wrote:
> Hi Jonathan,
>
> I got an error with the patch.
> arch/arm/dts/sun50i-h5-nanopi-neo-plus2.dtb: ERROR (phandle_references):
> Reference to non-existent node or label "reg_gmac_3v3"
>
> the attached patch, with reg_gmac_3v3, works for me.
>
> -antony
>
>
> On Fri, May 18, 2018 at 07:56:07AM -0500, Jonathan A. Kollasch wrote:
> > add arm64 H5 dwmac-sun8i support for this board
> >
> > commit arm64: dts: allwinner: h5: NanoPi NEO Plus2 : add EMAC support
> > ("27d7f929702739c186e72a4dcd255e0faa3beefc") from torvalds/linux
> >
> > Signed-off-by: Jonathan A. Kollasch <jakll...@kollasch.net>
> > ---
> >
> > arch/arm/dts/sun50i-h5-nanopi-neo-plus2.dts | 17 +++++++++++++++++
> > 1 file changed, 17 insertions(+)
> >
> > diff --git a/arch/arm/dts/sun50i-h5-nanopi-neo-plus2.dts
> > b/arch/arm/dts/sun50i-h5-nanopi-neo-plus2.dts
> > index f1406c224b..aadc087775 100644
> > --- a/arch/arm/dts/sun50i-h5-nanopi-neo-plus2.dts
> > +++ b/arch/arm/dts/sun50i-h5-nanopi-neo-plus2.dts
> > @@ -52,6 +52,7 @@
> > compatible = "friendlyarm,nanopi-neo-plus2", "allwinner,sun50i-h5";
> >
> > aliases {
> > + ethernet0 = &emac;
> > serial0 = &uart0;
> > };
> >
> > @@ -71,6 +72,22 @@
> > status = "okay";
> > };
> >
> > +&emac {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&emac_rgmii_pins>;
> > + phy-supply = <®_gmac_3v3>;
> > + phy-handle = <&ext_rgmii_phy>;
> > + phy-mode = "rgmii";
> > + status = "okay";
> > +};
> > +
> > +&external_mdio {
> > + ext_rgmii_phy: ethernet-phy@7 {
> > + compatible = "ethernet-phy-ieee802.3-c22";
> > + reg = <7>;
> > + };
> > +};
> > +
> > &mmc0 {
> > pinctrl-names = "default";
> > pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin>;
> > --
> > 2.11.0
> >
> From 71dd3f0c55a80036273d329677266d9ed98026fa Mon Sep 17 00:00:00 2001
> From: Antony Antony <ant...@phenome.org>
> Date: Fri, 18 May 2018 15:09:06 +0200
> Subject: [PATCH] arm64: dts: allwinner: h5: NanoPi NEO Plus2 : add EMAC,
> dwmac-sun8i
>
> commit arm64: dts: allwinner: h5: NanoPi NEO Plus2 : add EMAC support
> ("27d7f929702739c186e72a4dcd255e0faa3beefc") from torvalds/linux
>
> reg_gmac_3v3 from commit d7341305863bc
>
> Signed-off-by: Antony Antony <ant...@phenome.org>
> ---
> arch/arm/dts/sun50i-h5-nanopi-neo-plus2.dts | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/arch/arm/dts/sun50i-h5-nanopi-neo-plus2.dts
> b/arch/arm/dts/sun50i-h5-nanopi-neo-plus2.dts
> index f1406c2..b255190 100644
> --- a/arch/arm/dts/sun50i-h5-nanopi-neo-plus2.dts
> +++ b/arch/arm/dts/sun50i-h5-nanopi-neo-plus2.dts
> @@ -52,6 +52,7 @@
> compatible = "friendlyarm,nanopi-neo-plus2", "allwinner,sun50i-h5";
>
> aliases {
> + ethernet0 = &emac;
> serial0 = &uart0;
> };
>
> @@ -59,6 +60,17 @@
> stdout-path = "serial0:115200n8";
> };
>
> + reg_gmac_3v3: gmac-3v3 {
> + compatible = "regulator-fixed";
> + pinctrl-names = "default";
> + regulator-name = "gmac-3v3";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + startup-delay-us = <100000>;
> + enable-active-high;
> + gpio = <&pio 3 6 GPIO_ACTIVE_HIGH>;
> + };
> +
> reg_vcc3v3: vcc3v3 {
> compatible = "regulator-fixed";
> regulator-name = "vcc3v3";
> @@ -71,6 +83,22 @@
> status = "okay";
> };
>
> +&emac {
> + pinctrl-names = "default";
> + pinctrl-0 = <&emac_rgmii_pins>;
> + phy-supply = <®_gmac_3v3>;
> + phy-handle = <&ext_rgmii_phy>;
> + phy-mode = "rgmii";
> + status = "okay";
> +};
> +
> +&external_mdio {
> + ext_rgmii_phy: ethernet-phy@7 {
> + compatible = "ethernet-phy-ieee802.3-c22";
> + reg = <7>;
> + };
> +};
> +
> &mmc0 {
> pinctrl-names = "default";
> pinctrl-0 = <&mmc0_pins_a>, <&mmc0_cd_pin>;
> --
> 2.7.4
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
