Hello Prafulla, do you have some comments on the following 2 points? (If they are clarified, I can post v4 of the patch ...)
Heiko Schocher wrote: > Prafulla Wadaskar wrote: >>> -----Original Message----- >>> From: Heiko Schocher [mailto:h...@denx.de] >>> Sent: Monday, February 01, 2010 1:07 PM >>> To: U-Boot user list >>> Cc: Wolfgang Denk; Prafulla Wadaskar; Tom >>> Subject: [PATCH 2/2 v3] arm: suen3, suen3_v1, mgcoge2_arm_p1a support >>> >>> This patch adds support for the Keymile SUEN3 board variants which >>> are based on the Marvell Kirkwood (88F6281) SoC. All variants >>> uses common code stored in board/keymile/km_arm/km_arm.c >>> >>> mgcoge2_arm_p1a board: >>> This adds support for the ARM part of the mgcoge2. The suen3 >>> target was moved to the correct suen3 p1b version. There is a >>> difference between the GPIO configuration between suen3 and mgcoge2. >>> >>> Signed-off-by: Holger Brunck <holger.bru...@keymile.com> >>> Signed-off-by: Stefan Roese <s...@denx.de> >>> Signed-off-by: Heiko Schocher <h...@denx.de> >>> --- >>> - changes since v1: >>> added comments from Wolfgang Denk: >>> get rid of flash_info_t define in board config >>> (to get this working patch 1/2 is introduced/needed) >>> - changes since v2: >>> added comments from Wolfgang Denk >>> - rearranged if/else in do_spi_toggle() >>> - added I/O accessor functions for bootcounter >>> >>> MAINTAINERS | 2 + >>> MAKEALL | 4 + >>> Makefile | 8 + >>> board/keymile/common/common.c | 23 ++- >>> board/keymile/km_arm/Makefile | 51 +++++ >>> board/keymile/km_arm/config.mk | 25 +++ >>> board/keymile/km_arm/km_arm.c | 343 >>> +++++++++++++++++++++++++++++++++ >>> board/keymile/km_arm/sdramregs.txt | 31 +++ >>> board/keymile/km_arm/sdramregs_v1.txt | 28 +++ >>> include/configs/km-arm.h | 189 ++++++++++++++++++ [...] >>> include/configs/mgcoge2_arm_p1a.h | 96 +++++++++ >>> include/configs/suen3.h | 103 ++++++++++ >>> include/configs/suen3_p1a.h | 82 ++++++++ >>> include/configs/suen3_p1b_p1c.h | 110 +++++++++++ >> ...snip... >> >> the include/config files indicates that there are five board supports. >> Please provide one patch for each board, may be first will be master one. > > This question also asked Tom, see: > > http://lists.denx.de/pipermail/u-boot/2010-January/067182.html > > But if you prefer to split this in 5 patches, I can do it. Is it OK in one patch, or should I split it in 4 patches? [...] >>> diff --git a/board/keymile/km_arm/sdramregs.txt >>> b/board/keymile/km_arm/sdramregs.txt >>> new file mode 100644 >>> index 0000000..68c53a7 >>> --- /dev/null >>> +++ b/board/keymile/km_arm/sdramregs.txt >>> @@ -0,0 +1,31 @@ >> What is this file? >> Which license? >> Who is using it? > > Ok, you are right, some comments are here necessary. > > On this boards is a preloader, which initializes > the RAM. Therefore the preloader reads the RAM settings > from the image he should load, through an header. This > header is created with a tool doimage (I think it is > from marvell), and this tool needs this file ... > > So, I have no idea where to put this files, and think > they are in the board directory on the right place ... > > I found something similiar in current mainline: > > board/Marvell/mv88f6281gtw_ge/dramregs_333h.txt > > This file is also without comments, license info ... > Maybe this tool don;t accept comments? What should I do with this file? bye Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
