Re: [U-Boot] [PATCH] tools: adopt --std=gnu99 where C99 comments are needed

[Tom Rini]

On Mon, May 14, 2018 at 01:53:50PM +0200, Philipp Tomsich wrote:

> Following the conversion of the SPDX license tags, a number of files
> compiled with -pedantic now generate warnings similar to the following
> for using C99-style '//' comments in ISO C90 code:
> 
>   tools/gen_eth_addr.c:1:1: warning: C++ style comments are not allowed in 
> ISO C90
>    // SPDX-License-Identifier: GPL-2.0+
>    ^
> 
> The SPDX comment-style change means that these files have adopted C99,
> so we change the language-standard to --std=gnu99 to let the compiler
> know this.
> 
> References: commit 83d290c56fab ("SPDX: Convert all of our single license 
> tags to Linux Kernel style")
> Signed-off-by: Philipp Tomsich <philipp.toms...@theobroma-systems.com>
> ---
> 
>  tools/Makefile | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/tools/Makefile b/tools/Makefile
> index 5dd33ed..079d902 100644
> --- a/tools/Makefile
> +++ b/tools/Makefile
> @@ -38,11 +38,11 @@ hostprogs-$(CONFIG_BUILD_ENVCRC) += envcrc
>  envcrc-objs := envcrc.o lib/crc32.o env/embedded.o lib/sha1.o
>  
>  hostprogs-$(CONFIG_CMD_NET) += gen_eth_addr
> -HOSTCFLAGS_gen_eth_addr.o := -pedantic
> +HOSTCFLAGS_gen_eth_addr.o := --std=gnu99 -pedantic
>  
>  hostprogs-$(CONFIG_CMD_NET) += gen_ethaddr_crc
>  gen_ethaddr_crc-objs := gen_ethaddr_crc.o lib/crc8.o
> -HOSTCFLAGS_gen_ethaddr_crc.o := -pedantic
> +HOSTCFLAGS_gen_ethaddr_crc.o := --std=gnu99 -pedantic
>  
>  hostprogs-$(CONFIG_CMD_LOADS) += img2srec
>  HOSTCFLAGS_img2srec.o := -pedantic

The above highlights an interesting problem.  We have a lot of files in
tools/ without SPDX tags, and this is because in a number of cases
they're not easily tagable.  Setting aside that bit of un-fun legal
work, can we just add --std=gnu99 to HOSTCFLAGS in all cases, say around
where we define the wrap command in that Makefile?  All of the cases
without a tag should get fixed at some point and this will future proof
us.  Thanks!

-- 
Tom

signature.asc
Description: PGP signature

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot