On Tue, Apr 17, 2018 at 10:10 AM, Simon Glass <s...@chromium.org> wrote: > Hi Duncan, > > On 14 April 2018 at 17:43, <d...@synoia.com> wrote: >> From: Duncan Hare <duncanch...@yahoo.com> >> >> Why http and wget: >> >> HTTP is the most efficient file retrieval protocol in common >> use. The client send a single request, after TCP connection, >> to receive a file of any length. >> >> WGET is the application which implements http file transfer >> outside browsers as a file transfer protocol. Versions of >> wget exists on many operating systems. >> END > > Why END?
I would assume that (from reading this blurb) this is really a series cover letter and the END would terminate that... so the Cover-letter: tag is probably malformed. Which begs the question, where the actual log is for the wget patch? >> >> Signed-off-by: Duncan Hare <duncanch...@yahoo.com> >> --- >> >> Changes in v10: None > > There is no change log here. Has nothing changed since v1? Duncan has been struggling to use patman effectively. > > This code looks OK to me, but please can you run it through patman? I > see what look like some style errors. This is after using patman since v2 or so. > > How can we create a test for this? Can we add something to test_net.py ? > > Regards, > Simon > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot