Hi Michal, On 19 April 2018 at 08:10, Michal Simek <michal.si...@xilinx.com> wrote: > From: Ezequiel Garcia <ezequ...@vanguardiasur.com.ar> > > This driver is currently broken, refusing to initialize properly. > > The reason is that get_nand_dev_by_index() was being called before > nand_register(), thus returning a pointer into uninitialized memory. > In other words, the struct mtd_info used by the driver is total junk. > > Fix it by getting the correct struct mtd_info, via nand_to_mtd() > on the driver's struct nand_chip. > > Tested on a custom board, where the CPU is halted without this patch. > > Signed-off-by: Ezequiel Garcia <ezequ...@vanguardiasur.com.ar> > Reviewed-by: Michal Simek <michal.si...@xilinx.com> > Signed-off-by: Michal Simek <michal.si...@xilinx.com>
Thanks for collecting these and submitting them! BTW, I thought there was no need for a reviewed-by on top of a signed-off-by. It's kind of assumed that if you are signing something, you have reviewed it in the first place. Or at least that's how I've been doing it. -- Ezequiel García, VanguardiaSur www.vanguardiasur.com.ar _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
