On Tue, Apr 10, 2018 at 04:16:14PM +0200, Michal Simek wrote: > On 10.4.2018 16:08, Tom Rini wrote: > > On Mon, Apr 09, 2018 at 04:39:29PM +0200, Michal Simek wrote: > > > >> Hi Tom, > >> > >> please pull these changes to your tree. > >> > >> Travis looks good. > >> https://travis-ci.org/michalsimek/u-boot/builds/364047688 > >> > >> And buildman output too. > >> > >> Thanks, > >> Michal > >> > >> > >> The following changes since commit > >> 5bc0543df3079add8152afa041b887d081d71839: > >> > >> treewide: Convert CONFIG_HOSTNAME to a string option (2018-04-08 > >> 18:31:09 -0400) > >> > >> are available in the git repository at: > >> > >> git://www.denx.de/git/u-boot-microblaze.git tags/xilinx-for-v2018.05-rc2 > >> > >> for you to fetch changes up to f190eaf002bf1434587d57c726b3dabfabbc8074: > >> > >> arm64: zynqmp: Add support for Xilinx zcu111-revA (2018-04-09 12:14:53 > >> +0200) > >> > > > > Applied to u-boot/master, thanks! > > > > But a small request. A number of Xilinx have commits in the form of: > > Author: Their Name <their.n...@xilinx.com> > > ... > > Signed-off-by: Their Name: <tn...@xilinx.com> > > > > Which is fine in that it's clear that the Author also S-o-B'd it. But > > since the email doesn't match is does trigger my script that shows me > > the log to manually confirm the author S-o-B'd it. Can you please ask > > the team to check their gitconfig? Thanks! > > Xilinx is allowing to have email setup in both forms.
That's fairly common. FWIW, it pops up sometimes for TI and
NXP/Freescale (I don't know if it will follow over to qcom).
> I see that Siva, Nitin, Vipul and maybe others have that incorrect setting.
> Do you have that script somewhere to also include it to my flow to make
> sure that this is aligned when I accept these patches internally too?
Sure. This is ugly, but functional:
#!/bin/bash
COMMITS=`git log --no-merges origin/master.. --oneline | wc -l`
SIGNS=`mktemp`
for HASH in `git log --no-merges origin/master.. --format=%h`;do EMAIL=`git log
-n1 --format=%ae $HASH`; git log --grep="Signed-off-by.*$EMAIL"
${HASH}^..${HASH} --format="Commit %h is OK";done > $SIGNS
if test $COMMITS -ne `cat $SIGNS | wc -l`;then
echo Problematic commits exist:
for HASH in `git log --no-merges origin/master.. --format=%h`;do
EMAIL=`git log -n1 --format=%ae $HASH`; git log --grep="Signed-off-by.*$EMAIL"
--invert-grep ${HASH}^..${HASH};done
rm -f $SIGNS
exit 1
else
rm -f $SIGNS
echo "All commits appear OK"
fi
--
Tom
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
