> Lukasz Majewski <[email protected]> hat am 14. März 2018 um 18:24 geschrieben: > > > This patch adds support for incrementation of the bootcount in SPL. > Such feature is necessary when we do want to use this feature with > 'falcon' boot mode (which loads OS directly in SPL). > > Signed-off-by: Lukasz Majewski <[email protected]> > > --- > > Changes in v2: > - New patch - as suggested by Stefan Roese - bootcount_inc() is called > in common SPL code (./common/spl/spl.c), so other boards can also > reuse it without modification > > common/spl/spl.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/common/spl/spl.c b/common/spl/spl.c > index b1ce56d0d0..01e7989869 100644 > --- a/common/spl/spl.c > +++ b/common/spl/spl.c > @@ -20,6 +20,9 @@ > #include <dm/root.h> > #include <linux/compiler.h> > #include <fdt_support.h> > +#ifdef CONFIG_SPL_BOOTCOUNT_LIMIT > +#include <bootcount.h> > +#endif
Is this #ifdef necessary? If not, please remove it. > > DECLARE_GLOBAL_DATA_PTR; > > @@ -411,6 +414,10 @@ void board_init_r(gd_t *dummy1, ulong dummy2) > spl_board_init(); > #endif > > +#ifdef CONFIG_SPL_BOOTCOUNT_LIMIT > + bootcount_inc(); > +#endif > + I think you can remove this #ifdef as well here. You have the #ifdef in the header already. Thanks, Stefan _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
