Hi Stephen, On Tue, 13 Mar 2018 at 17:22 Stephen Warren <[email protected]> wrote:
> On 03/03/2018 09:32 AM, Liam Beguin wrote: > > On 1 March 2018 at 16:56, Stephen Warren <[email protected]> wrote: > >> On 02/26/2018 09:17 PM, Liam Beguin wrote: > >>> > >>> Add basic tests for the spi_flash subsystem. > >> > >> > >>> diff --git a/test/py/tests/test_sf.py b/test/py/tests/test_sf.py > >> > >> > >>> +import re > >>> +import pytest > >>> +import u_boot_utils > >>> + > >>> + > >> > >> > >> Nit: Double blank line. The same issue exists in many other places too. > > > > This is because I use flake8 and it was complaining if I didn't. > Apparently > > PEP8 suggests you surround top level functions with 2 blank lines. > > I really have no preference. > > Hmm. There are some things about PEP8 I'm not so found of. Either way > though, I don't believe any current code in test/py uses double blank > lines, and I /think/ the same is true for other Python code in U-Boot. > As I said, I don't have any preference but you're right, consistency is best. I'll remove them in v3. > > Looks like I don't have any other comments on your replies. > Thanks, Liam Beguin _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
