Hi everyone, Any new comments on this iteration?
Thanks, Liam On Sun, 4 Mar 2018 at 23:22 Liam Beguin <[email protected]> wrote: > Hi all, > > This is the inital step to adding tests for the SF subsystem plus very > minor fixes. It is based on work I found on the mailing list[1]. > For now, it doesn't do much but I plan on adding code to reset the flash > to its initial state (based on an env flag) and more code to test the > `sf protect` subcommand (which is the main goal of this series). > I'm sending it now to make sure it's headed in the right direction. > > Base on Stephen's comment[2], I haven't added the radomized features. > I'll see how this iteration goes and maybe add it later. > > Changes since v1: > - remove unnecessary skip flag from environment > - move crc32() to u_boot_utils.py and add extra checks > - rewrite sf_prepare to return a dict of parameter > - use assert instead of pytest.fail > - remove verbose from sf_prepare() > - update documentation > - improve readability > - use ' consistently instead of " > - use sf_read() in test_sf_read() > - rename crc variables > - add speed parameter with optional random range > - allow `sf read` to write at 0x00 > > Thanks, > Liam Beguin > > [ 1 ] https://patchwork.ozlabs.org/patch/623061/ > [ 2 ] https://lists.denx.de/pipermail/u-boot/2018-March/321688.html > > Liam Beguin (8): > spi: spi_flash: do not fail silently on bad user input > cmd: sf: fix map_physmem check > test/py: README: fix typo > test/py: README: add HOSTNAME to PYTHONPATH > test/py: do not import pytest multiple times > test/py: add generic CRC32 function > test/py: add spi_flash tests > > cmd/sf.c | 2 +- > drivers/mtd/spi/spi_flash.c | 2 +- > test/py/README.md | 6 +- > test/py/tests/test_sf.py | 223 > ++++++++++++++++++++++++++++++++++++++++++++ > test/py/u_boot_utils.py | 24 ++++- > 5 files changed, 251 insertions(+), 6 deletions(-) > create mode 100644 test/py/tests/test_sf.py > > > base-commit: 77bba970e2372b01156c66585db3d6fc751c7178 > Published-As: https://github.com/Liambeguin/u-boot/releases/tag/test_sf-v2 > > -- > 2.16.1.72.g5be1f00a9a70 > > _______________________________________________ U-Boot mailing list [email protected] https://lists.denx.de/listinfo/u-boot
