Mike Frysinger wrote:
> On Saturday 23 January 2010 20:18:04 Tom wrote:
>> Mike Frysinger wrote:
>>> Signed-off-by: Mike Frysinger <vap...@gentoo.org>
>>> ---
>>> note: havent compile tested this, but it should be straight forward ...
>> I have compile tested this.
>> It is fine.
>>
>> Was this run tested ?
>
> if i cant compile. i cant run
In some case people do a runtime test without doing a full compile test
with MAKEALL arm. I was hoping this was the case.
>
>> I see this was imported from the kernel.
>
> if that's true, that isnt "my problem". i modified files that existed in u-
> boot already; i did not myself copy directly from the linux kernel. feel
> free
> to add any comments/etc... you find appropriate.
> -mike
On reviewing 1/3 closer against the linux kernel
diff .../linux-2.6-arm/include/asm-generic/unaligned.h
.../u-boot-arm/include/asm-generic/unaligned.h
It looks like the version from the kernel could be used without
modifications. It looks very similar to your patch.
This is the commit from the kernel
aafe4dbed0bf6cbdb2e9f03e1d42f8a540d8541d
asm-generic: add generic versions of common headers
These are all kernel internal interfaces that get copied
around a lot. In most cases, architectures can provide
their own optimized versions, but these generic versions
can work as well.
I have tried to use the most common contents of each
header to allow existing architectures to migrate easily.
Thanks to Remis for suggesting a number of cleanups.
Signed-off-by: Remis Lima Baima <remis.develo...@googlemail.com>
Signed-off-by: Arnd Bergmann <a...@arndb.de>
I would prefer to reuse the kernel source where possible.
Tom
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
