Wolfgang Denk: > I don't like to see such heavy copying of code. This is a clear > indication that we should factor out the common parts
While I disagree (as explained), I'm trying hard to do it. Unfortunately what is currently a Makefile decision (COBJS-y and such) will sometimes become ifdef in the code. However, i've moved platform.S and lcd.c to the cpu directory, so they can be shared (the assembly really ought to be personalized for each board, as some cruft is still there from past history, and the lcd.c is really two small data structures, but let's ignore this by now). Now, reading better your message I see this that I don't understand. > Actually differences are so small that common code can be used > completely, and no separate board directories are needed. On one side we are asked to use the vendor directories, and now I should merge vendor/st/nhk8815 and vendor/calao/usb-8815. Now, I wonder where am I expected to place che board files. In cpu/arm926ejs/nomadik ? And using #ifdef in a single file to sort out differences? I got the idea a board should be a separate object (directory), which bases on the available infrastructure to pick up pieces and define own parameters. Adding a board should be as easy as adding a directory. Such parameters sometimes happen to match other parameters, but coalescing two boards just to save a few lines is not an advantage, in my opinion. Could you please explain how to proceed to have both boards upstream in the best possible way? I currently don't understand the policy. Please forgive me if the message looks aggressive. It's not meant to be, but ascii doesn't proprely convey tone. /alessandro _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
