Dear Tom Rini, In message <20180224215325.GQ4311@bill-the-cat> you wrote: > > > Why do you ignore this NAK, and why do you add this patch so late in > > the release cycle anyway? > > Sorry, didn't v2 address your concerns? We don't initialize the device > because maybe we'll have env there, we initalize mmc because we need to > check that it is there. Thanks!
No, it does not. As is, we initialize MMC in the EXT4 code (in env_ext4_load()). If we go that route, we would have to add similar init calls to all other file systemn load routines as well. This does not make sense to me. This pollutes the code with unrelated things - file system code should not depend on any underlaying driver suport. It increases code size, makes the code harder to maintain (if you need to change this, there is good chances to forget the same change in other file systems), and there is a good chance that in the end you will initialzie MMC even if you don't use it. We should keep the code clean and orthogonal. Driver init code has no place in file system code. If needed, the drivers have to make sure to auto--initialize on first access. I hold my NAK on this patch. It is the wrong thing to do. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A meeting is an event at which the minutes are kept and the hours are lost. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
