On 6.2.2018 04:02, Tom Rini wrote: > On Wed, Jan 31, 2018 at 04:09:57PM +0100, Michal Simek wrote: > >> There is no reason to unconditially select network commands as distro >> defaults. Systems without ethernet but with sd, sata, usb should also be >> able to use distro defaults. Use imply instead of select. >> >> Signed-off-by: Michal Simek <michal.si...@xilinx.com> >> --- >> >> Kconfig | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/Kconfig b/Kconfig >> index 9b8a8077993a..55bb00936cf7 100644 >> --- a/Kconfig >> +++ b/Kconfig >> @@ -69,14 +69,14 @@ config DISTRO_DEFAULTS >> imply USE_BOOTCOMMAND >> select CMD_BOOTZ if ARM && !ARM64 >> select CMD_BOOTI if ARM64 >> - select CMD_DHCP >> - select CMD_PXE >> + imply CMD_DHCP >> + imply CMD_PXE >> select CMD_EXT2 >> select CMD_EXT4 >> select CMD_FAT >> select CMD_FS_GENERIC >> - select CMD_MII >> - select CMD_PING >> + imply CMD_MII >> + imply CMD_PING >> select CMD_PART >> select HUSH_PARSER >> help > > Should we perhaps use select CMD_DHCP if NET, etc? There's a certain > level of non-opt-outedness that's supposed to be here, so long as the > underlying functionality is there. And a follow-up might be that a > bunch more CMDs need to be nested under / depend on NET to start with. > But that's just a thought. Thanks!
Not a problem. I will take a look at cmd_net and phylib which should depends on net and will send v2. Thanks, Michal _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot