Hi Masahiro, On 27 January 2018 at 14:28, Masahiro Yamada <yamada.masah...@socionext.com> wrote: > Hi Simon, > > > 2018-01-27 0:27 GMT+09:00 Simon Glass <s...@chromium.org>: >> Hi Masahiro, >> >> On 21 January 2018 at 02:34, Masahiro Yamada >> <yamada.masah...@socionext.com> wrote: >>> All of these host tools are apparently written for Python2, >>> not Python3. >>> >>> Use 'python2' in the shebang line according to PEP 394 >>> (https://www.python.org/dev/peps/pep-0394/). >>> >>> Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com> >>> --- >>> >>> I sent some time before figuring out why Patman does not work >>> on my machine. >>> >>> If 'python' points to python3, Patman does not epit any error >>> message, it just stays silent until it consumes all memory >>> on the system. >>> >>> >>> scripts/dtc/pylibfdt/setup.py | 2 +- >>> scripts/mailmapper | 2 +- >>> test/py/test.py | 2 +- >>> tools/buildman/buildman.py | 2 +- >>> tools/dtoc/dtoc.py | 2 +- >>> tools/microcode-tool.py | 2 +- >>> tools/patman/patman.py | 2 +- >>> tools/rkmux.py | 2 +- >>> 8 files changed, 8 insertions(+), 8 deletions(-) >> >> Reviewed-by: Simon Glass <s...@chromium.org> >> >> I can repeat that problem. There has been some effort to make patman >> (in particular) work with python 3. Should we fix the bug? This change >> will mask it. >> > > I do not think this is a bug. > > If 'python2' is specified in the shebang line, > users should not run it under python 3.
I mean the bug that makes patman hang. I thought that patman ran with Python 3. It has been converted but apparently does not run. > > Python 2 will retire in 2020 > (https://pythonclock.org/), > we need to covert our python scripts > to python 3 at some point in the future. > '2to3' tool is useful, but not perfect. > Then, we will need to take a look into problems > during the conversion. > > Also, I believe we should use python 2 only for existing tools. > New python scripts should be all written in python 3. > (If they are written in python 2, > should be rejected in the review.) That sounds OK to me, but I think we should convert existing tools too. Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
