Khasim Syed Mohammed wrote:
> Hi Tom,
>
> On Sun, Jan 17, 2010 at 5:44 AM, Tom <tom....@windriver.com> wrote:
>> Khasim Syed Mohammed wrote:
>>> From 15fbe5ff9ee2fd2f8da4c16805d6c7ccf7244bae Mon Sep 17 00:00:00 2001
>>> From: Syed Mohammed Khasim <kha...@ti.com>
>>> Date: Fri, 8 Jan 2010 20:13:47 +0530
>>> Subject: [PATCH] OMAP3 Beagle Update revision detection
>>>
>> <snip>
>>
>>> MUX_BEAGLE();
>>>
>>> - if (beagle_revision_c) {
>>> + if (beagle_revision != REVISION_AXBX)
>>> MUX_BEAGLE_C();
>>> - }
>> Because MUX_BEAGLE_C is a multiline macro,
>> it would be good to keep the '{ }'
>>
> I had this before, but it resulted in Checkpatch error, do you still
> want me to keep { } ?,
>
Yes.
Checkpatch is not smart enough to figure out if it is function or
a macro.
Because macros are better behaved in a '{ }', block I prefer that.
Tom
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
