On Tue, Jan 16, 2018 at 10:47:43AM -0700, Stephen Warren wrote: > On 01/15/2018 06:53 AM, Tom Rini wrote: > >On Fri, Jan 12, 2018 at 10:37:06AM -0700, Tom Warren wrote: > > > >>Tom, > >> > >>Please pull u-boot-tegra/master into U-Boot/master. Thanks! > >> > >>All Tegra builds are OK, and Stephen's automated test system reports that > >>all tests pass. > >> > >>The following changes since commit 373b9003410b44a1133060c2e63483b278fb476b: > >> > >> Merge git://git.denx.de/u-boot-sunxi (2018-01-11 14:14:19 -0500) > >> > >>are available in the git repository at: > >> > >> git://git.denx.de/u-boot-tegra.git master > >> > >>for you to fetch changes up to 5fed97af20da955625cc06563a725b49cebb99eb: > >> > >> Makefile: ensure DTB doesn't overflow into initial stack (2018-01-12 > >>10:12:32 -0700) > > > >Applied to u-boot/master, thanks! > > > >But please note the following checkpatch.pl issues that should be looked > >into and possibly addressed: > > Most of these are due to importing code verbatim from the Linux kernel. I > figured that keeping the code identical to upstream was better than locally > fixing the checkpatch issues and putting the two sets of source out-of-sync.
Agreed.
> I believe the only two things I introduced were:
>
> >ERROR: space required after that close brace '}'
> >#44: FILE: arch/arm/mach-tegra/tegra186/nvtboot_mem.c:32:
> >+} ram_banks[CONFIG_NR_DRAM_BANKS] = {{1}};
>
> That's a bogus issue.
>
> >total: 1 errors, 0 warnings, 0 checks, 48 lines checked
> >WARNING: externs should be avoided in .c files
> >#58: FILE: arch/arm/mach-tegra/tegra186/nvtboot_mem.c:32:
> >+extern struct mm_region tegra_mem_map[];
> >
> >total: 0 errors, 1 warnings, 0 checks, 138 lines checked
> >WARNING: externs should be avoided in .c files
> >#53: FILE: arch/arm/mach-tegra/tegra186/nvtboot_board.c:29:
> >+extern struct mm_region tegra_mem_map[];
>
> I suppose those could be fixed.
Thanks for looking!
--
Tom
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
