On 12/01/2018 13:39, Bryan O'Donoghue wrote:
> Both usages of authenticate_image treat the result code as a simple binary.
> The command line usage of authenticate_image directly returns the result
> code of authenticate_image as a success/failure code.
>
> Right now when calling hab_auth_img and test the result code in a shell a
> passing hab_auth_img will appear to the shell as a fail.
>
> The first step in fixing this behaviour is to fix-up the result code return
> by authenticate_image() itself, subsequent patches fix the interpretation
> of authenticate_image so that zero will return CMD_RET_SUCCESS and non-zero
> will return CMD_RET_FAILURE.
>
> The first step is fixing the return type in authenticate_image() so do that
> now.
Thanks for your series - applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonog...@linaro.org>
> Cc: Stefano Babic <sba...@denx.de>
> Cc: Fabio Estevam <fabio.este...@nxp.com>
> Cc: Peng Fan <peng....@nxp.com>
> Cc: Albert Aribaud <albert.u.b...@aribaud.net>
> Cc: Sven Ebenfeld <sven.ebenf...@gmail.com>
> Cc: George McCollister <george.mccollis...@gmail.com>
> Cc: Breno Matheus Lima <brenomath...@gmail.com>
> Tested-by: Breno Lima <breno.l...@nxp.com>
> Reviewed-by: Fabio Estevam <fabio.este...@nxp.com>
> ---
> arch/arm/include/asm/mach-imx/hab.h | 2 +-
> arch/arm/mach-imx/hab.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/include/asm/mach-imx/hab.h
> b/arch/arm/include/asm/mach-imx/hab.h
> index e0ff459..1b7a5e4 100644
> --- a/arch/arm/include/asm/mach-imx/hab.h
> +++ b/arch/arm/include/asm/mach-imx/hab.h
> @@ -145,6 +145,6 @@ typedef void hapi_clock_init_t(void);
>
> /* ----------- end of HAB API updates ------------*/
>
> -uint32_t authenticate_image(uint32_t ddr_start, uint32_t image_size);
> +int authenticate_image(uint32_t ddr_start, uint32_t image_size);
>
> #endif
> diff --git a/arch/arm/mach-imx/hab.c b/arch/arm/mach-imx/hab.c
> index 02c7ae4..09892a6 100644
> --- a/arch/arm/mach-imx/hab.c
> +++ b/arch/arm/mach-imx/hab.c
> @@ -410,7 +410,7 @@ static bool is_hab_enabled(void)
> return (reg & IS_HAB_ENABLED_BIT) == IS_HAB_ENABLED_BIT;
> }
>
> -uint32_t authenticate_image(uint32_t ddr_start, uint32_t image_size)
> +int authenticate_image(uint32_t ddr_start, uint32_t image_size)
> {
> uint32_t load_addr = 0;
> size_t bytes;
>
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=====================================================================
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
