Hi Tom, Martyn, On 18/12/2017 18:22, Tom Rini wrote: > On Sun, Dec 17, 2017 at 10:50:49PM +0100, Stefano Babic wrote: > >> Hi Tom, >> >> please pull from u-boot-imx ("power: pmic/regulator allow dm be omitted >> by SPL" dropped), thanks ! >> >> The following changes since commit fcc8250c2f7c982f3593a8eecf737f8e2c95f222: >> >> Merge git://git.denx.de/u-boot-mips (2017-11-28 16:54:30 -0500) >> >> are available in the git repository at: >> >> git://www.denx.de/git/u-boot-imx.git master >> >> for you to fetch changes up to 7efc2dbfb2fa04bd4111615a8afb0822d6b88b09: >> >> arm: imx: add tzic interrupt controller for imx53 (2017-12-17 22:34:01 >> +0100) >> >> ---------------------------------------------------------------- > [snip] >> Hannu Lounento (5): >> net: e1000: add support for writing to EEPROM >> net: e1000: split e1000_read_mac_addr >> net: e1000: implement eth_write_hwaddr >> board: ge: bx50v3: program MAC address to I210 > > This first patch adds a bunch of warnings about > e1000_update_eeprom_checksum_i210 being declared static and unused. > It's unused in the case of DM_ETH being set because we don't have > e1000_initialize and company compiled in, and thus no e1000_write_hwaddr > and thus no callers of e1000_update_eeprom_checksum_i210. Given that I > see on my calendar a reminder that in early 2018 I need to make a lack > of DM conversion of $X a lot louder of warning, are these 4 things > imporant fixes that must come in now, or something that can be baked a > bit longer?
They are not fixes, but they add a feature (writing the EEPROM) that is used by GE in the mx53ppd board. If I drop those, I had to remove all patches because they depend on these four. I can do, but I forward the question to Martyn who is the originator of the series. > > To see the warnings, build for say qemu-x86_64. Thanks! > I see, right, thanks. Martyn, can you take a lookt at this ? If we are not hurry, I can put your series in the -next branch of u-boot-imx and let Tom to pull without them. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot