Re: [U-Boot] [RFC] MUSB-UDC issues and fixes

[Mike Frysinger]

On Monday 11 January 2010 15:00:40 Juha Kuikka wrote:
> 2. On DM850 the MUSB interrupts are read from a wrapper, not from MUSB
> block . Add optional interface function to read-and-clear interrupts.
>
> +#ifndef CONFIG_MUSB_SOC_IRQ
> +static void musb_get_interrupts(u8 *usb, u16 *rx, u16 *tx)
> +{
> +     *usb = readb(&musbr->intrusb);
> +     *rx = readw(&musbr->intrrx);
> +     *tx = readw(&musbr->intrtx);
> +}
> +#else
> +extern void musb_get_interrupts(u8 *usb, u16 *rx, u16 *tx);
> +#endif

this looks like a static MUSB implementation rather than a config option a 
user/board would control, right ?  so perhaps we should stick with the 
"internal" symbol naming rather than CONFIG_MUSB_xxx ... e.g. the way we're 
handling dynamic fifos and/or multipoint.
-mike

signature.asc
Description: This is a digitally signed message part.

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot