It looks like the change I'm trying to revert got rejected a couple years ago in another form:
https://lists.denx.de/pipermail/u-boot/2015-August/224556.html In particular at the end Marek says: >> /* Indirect mode configurations */ >> writel((plat->sram_size/2), plat->regbase + CQSPI_REG_SRAMPARTITION); >> - writel((u32)plat->ahbbase & CQSPI_INDIRECTTRIGGER_ADDR_MASK, >> + writel((u32)plat->trigger_base, >> plat->regbase + CQSPI_REG_INDIRECTTRIGGER); > >Here you actually changed to logic of the code, which breaks it for SoCFPGA. >plat->ahbbase & CQSPI_INDIRECTTRIGGER_ADDR_MASK = 0x0 for SoCFPGA, but now >you changed it such that 0xffa00000 is written into the register. Same does >apply for all your changes below. On Sun, Dec 3, 2017 at 10:54 AM, Fabio Estevam <feste...@gmail.com> wrote: > On Sun, Dec 3, 2017 at 1:51 PM, Frank Mori Hess <fmh...@gmail.com> wrote: >> On Sun, Dec 3, 2017 at 10:49 AM, Fabio Estevam <feste...@gmail.com> wrote: >>> On Sun, Dec 3, 2017 at 1:36 PM, Frank Mori Hess <fmh...@gmail.com> wrote: >>>> This reverts commit dac3bf20fb2c9b03476be0d73db620f62ab3cee1. >>> >>> Please explain the reasoning for the revert. >> >> It looks like my original post got stuck in moderation: > > You should explain inside the commit log why you think it is a good > idea to do the revert. -- Frank _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
