On 11/06/2017 05:15 AM, Chee, Tien Fong wrote: > On Ahd, 2017-11-05 at 17:43 +0100, Marek Vasut wrote: >> On 11/02/2017 09:20 AM, Chee, Tien Fong wrote: >>> >>> On Rab, 2017-11-01 at 10:26 +0100, Marek Vasut wrote: >>>> >>>> On 11/01/2017 10:18 AM, tien.fong.c...@intel.com wrote: >>>>> >>>>> >>>>> From: Tien Fong Chee <tien.fong.c...@intel.com> >>>>> >>>>> Generic firmware loader framework contains some common >>>>> functionality >>>>> which is factored out from splash loader. It is reusable by any >>>>> specific driver file system firmware loader. Specific driver >>>>> file >>>>> system >>>>> firmware loader handling can be defined with both weak function >>>>> fsloader_preprocess and fs_loading. >>>>> >>>>> Signed-off-by: Tien Fong Chee <tien.fong.c...@intel.com> >>>>> --- >>>>> common/Makefile | 1 + >>>>> common/load_fs.c | 217 >>>>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++ >>>>> include/load_fs.h | 38 ++++++++++ >>>>> 3 files changed, 256 insertions(+) >>>>> create mode 100644 common/load_fs.c >>>>> create mode 100644 include/load_fs.h >>>> [...] >>>> >>>>> >>>>> >>>>> +int flash_select_fs_dev(struct flash_location *location) >>>> Why does everything have flash_ prefix ? >>>> >>> I can remove the flash_ prefix, this generic FS loader should >>> support >>> for all filesystem instead of flash. >>> >>>> >>>> I also mentioned the API should copy the linux firmware loader >>>> API. >>>> >>> If i'm not mistaken, you are referring firmware loader API in this >>> link https://github.com/torvalds/linux/blob/f007cad159e99fa2acd3b2e >>> 9364 >>> fbb32ad28b971/drivers/base/firmware_class.c#L1264. >>> > I would like to confirm with you whether we are talking to the same API > above?
https://www.kernel.org/doc/html/v4.13/driver-api/firmware/index.html first link on google btw . You might be able to avoid the firmware structure. [...] -- Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
