Dear Himanshu Chauhan, In message <4b2b79a9.1000...@symmetricore.com> you wrote: > Stefan Roese wrote: > > On Friday 18 December 2009 13:20:56 Stefan Roese wrote: > >>> I think thats what it is. Both are same. > >> No, not exactly. They're nearly identical. But there are differences. Not > >> sure if these differences are important though. > >> > >> Don't get me wrong. I'm not NACK'ing the patch. I'm just pointing out that > >> it's different from the Linux version. > > > > Just to make it clear. Here a diff between both versions: > > > > --- u-boot/include/asm-mips/unaligned.h > > +++ linux-2.6/linus/arch/mips/include/asm/unaligned.h > > @@ -8,19 +8,21 @@ > > #ifndef _ASM_MIPS_UNALIGNED_H > > #define _ASM_MIPS_UNALIGNED_H > > > > -#include <compiler.h> > > +#include <linux/compiler.h> > > #if defined(__MIPSEB__) > > +# include <linux/unaligned/be_struct.h> > > +# include <linux/unaligned/le_byteshift.h> > > # define get_unaligned __get_unaligned_be > > # define put_unaligned __put_unaligned_be > > #elif defined(__MIPSEL__) > > +# include <linux/unaligned/le_struct.h> > > +# include <linux/unaligned/be_byteshift.h> > > # define get_unaligned __get_unaligned_le > > # define put_unaligned __put_unaligned_le > > #else > > # error "MIPS, but neither __MIPSEB__, nor __MIPSEL__???" > > #endif > > > > -# include <linux/unaligned/le_byteshift.h> > > -# include <linux/unaligned/be_byteshift.h> > > # include <linux/unaligned/generic.h> > > > > #endif /* _ASM_MIPS_UNALIGNED_H */ > > > > I think whatever Shinya sent was modified version of linux's unaligned.h > and its working.
Hm... has this really been tested on both big endian and on little endian MIPS systems? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "Beware of bugs in the above code; I have only proved it correct, not tried it." - Donald Knuth _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
