Hi Mario, On 29 September 2017 at 06:51, Mario Six <mario....@gdsys.cc> wrote: > The dev_read_addr function does not do any bus translations, and just > returns the raw address read from the device tree, which makes the > driver not work on systems that need bus translations to get the actual > memory address of the device's register space.
Aside from any current functionality, what is the correct thing for dev_read_addr() to do? I worry that the two parts (live/flat tree) might do different things. In any case, we should not compound the problem if dev_read_addr() is wrong. > > Since the dev_read_addr function is widely used, we refrain from > modifying it, and instead read the raw address from the device tree, and > apply the bus translations using the recently introduced > dev_translate_address function. > > Signed-off-by: Mario Six <mario....@gdsys.cc> > --- > drivers/serial/ns16550.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) REgards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
